On Thu, Jul 23, 2020 at 7:39 PM brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > On 2020-07-23 at 04:51:32, Eric Sunshine wrote: > > On Wed, Jul 22, 2020 at 9:11 PM brian m. carlson > > <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > > > + --hash=*) > > > + algo="${1#--hash=}" && > > > > Bikeshedding: I wonder if this should be named "--algo"? > > We already have a use of this in t5515; I appear to have accidentally > sent it in an earlier series. I can, of course, change it, but I don't > feel strongly that one or the other is better. If you do feel strongly, > or you think it's confusing, I'm happy to change it. I don't feel strongly about it and wouldn't insist that it be changed.