On Wed, Jul 22, 2020 at 06:41:33PM -0700, Junio C Hamano wrote: > Taylor Blau <me@xxxxxxxxxxxx> writes: > > >> If this die() were to show the same fancy error message as in the ERR > >> packet, then it would always make it to 'git clone's stderr in the > >> tests, so the tests could reliably check that 'git upload-pack' died > >> for the expected reason. > > > > Beautiful idea. I changed this in my fork, and I'll send it to this > > thread after 2.28 is out, since I don't want to create a distraction in > > the meantime. > > Thanks. > > As long as everybody understands that "distraction" will immediately > gets backburnered when a regression relevant to the upcoming release > is found, however, I think performing work as usual is a good thing. > After all, we often find glitches in the current code by trying to > build on it, in addition to using it. Fair enough ;-). I sent v2 a few minutes ago, but forgot to attach it to this thread as a reply. So, I suppose we can pick up the review there, instead. Thanks, Taylor
