Junio C Hamano <gitster@xxxxxxxxx> writes: >>> The optimization makes sense to me if certain >>> conditions are met, like... >>> >>> - Most of the time there is no missing object due to promisor, even >>> if has_promissor_to_remote() is true; >> >> I think that optimizing for this condition makes sense - most pushes (I >> would think) are pushes of objects we create locally, and thus no >> objects are missing. Another simple thing I missed. Why do we specifically refer to "push" here? Is this codepath in pack-objects not used or less often used by upload-pack (which is what serves "fetch")? I just wanted to make sure that we are not optimizing for "push", trading efficiency for "fetch" off. Thanks.
