Re: [PATCH] git-send-email: die if sendmail.* config is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Drew DeVault" <sir@xxxxxxxxx> writes:

> I originally had this just a warning, but it can be difficult to see.
> There's a lot of text printed from git send-email, a lot of it looks
> like diagnostics, and it can be easy to lose a message in there. And if
> you pass --annotate, which I encourage people to do, your editor
> immediately covers up the warning.

OK.

> I wonder if a happy medium would be adding a config option which
> squelches the message? If sendemail.squelchConfigError is set, for
> example.

I think with "squelches the message" replaced with "bypasses the
check", it would probably be a good idea.  It may be that a
reasonable behaviour would be to check for any "sendemail.*" and
die, like your version does, by default, an optional opt-out
configuration variable (sendemail.forbidSendmailVariables) to
disable the check entirely, and then add a hint that mentions the
variable to the "die" message in your patch.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux