On Thu, Jul 16, 2020 at 09:49:14AM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Subject: verify_repository_format(): complain about new extensions in v0 repo > > > > We made the mistake in the past of respecting extensions.* even when the > > repository format version was set to 0. This is bad because forgetting > > to bump the repository version means that older versions of Git (which > > do not know about our extensions) won't complain. I.e., it's not a > > problem in itself, but it means your repository is in a state which does > > not give you the protection you think you're getting from older > > versions. > > > > For compatibility reasons, we are stuck with that decision for existing > > extensions. However, we'd prefer not to extend the damage further. We > > can do that by catching any newly-added extensions and complaining about > > the repository format. > > Looking good overall, but I needed this to build from the source. Oof, thanks. I did this as a one-off not even on a branch, and my config.mak magic loosens -Werror in that case (because usually a detached HEAD means I'm investigating some old commit, and quite a few of them don't build without warnings these days). Thankfully it seems I only managed a minor error without the compiler there to help me. :) -Peff
