On 7/15/2020 2:09 PM, Junio C Hamano wrote:
> Derrick Stolee <stolee@xxxxxxxxx> writes:
>
>> Your previous diff had this comment, which I thought to be
>> helpful:
>>
>> + /*
>> + * Extensions are added by more "} else if (...) {"
>> + * lines here, but do NOT mark them as allowed in v0
>> + * by copy-pasting without thinking.
>> + */
>
> Yeah, but it felt somewhat strange to have it at the end of one
> entry, like this:
>
> + unallowed_in_v0 = 0;
> } else if (!strcmp(ext, "worktreeconfig")) {
> data->worktree_config = git_config_bool(var, value);
> + unallowed_in_v0 = 0;
> + /*
> + * Extensions are added by more "} else if (...) {"
> + * lines here, but do NOT mark them as allowed in v0
> + * by copy-pasting without thinking.
> + */
> + } else {
> string_list_append(&data->unknown_extensions, ext);
>
>
> In any case, I updated the comment in front of the if/else if/
> cascade to essentially say the same thing, and with test updates
> this time.
Thanks. I applied and tested this version. LGTM!
I'll also review Jonathan Nieder's patches when they arrive.
Thanks,
-Stolee
