On Thu, Jul 02, 2020 at 04:06:40PM -0400, Taylor Blau wrote:
> diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh
> index 5dcd0b5656..8781a24cfe 100755
> --- a/t/t5616-partial-clone.sh
> +++ b/t/t5616-partial-clone.sh
> @@ -261,6 +261,14 @@ test_expect_success 'upload-pack fails banned object filters with fallback' '
> test_i18ngrep "filter '\''blob:none'\'' not supported" err
> '
>
> +test_expect_success 'upload-pack limits tree depth filters' '
> + test_config -C srv.bare uploadpack.filter.allow false &&
> + test_config -C srv.bare uploadpack.filter.tree.allow true &&
> + test_config -C srv.bare uploadpack.filter.tree.maxDepth 0 &&
> + test_must_fail ok=sigpipe git clone --no-checkout --filter=tree:1 \
> + "file://$(pwd)/srv.bare" pc3
> +'
Unlike in the other three tests added earlier in this series, here you
do use 'test_must_fail ok=sigpipe', but you don't check that the
command died with the right error message. Saving stderr and adding
test_i18ngrep "filter '\''tree'\'' not supported (maximum depth: 0, but got: 1)" err
makes this test flaky, too, like the other three:
expecting success of 5616.20 'upload-pack limits tree depth filters':
test_config -C srv.bare uploadpack.filter.allow false &&
test_config -C srv.bare uploadpack.filter.tree.allow true &&
test_config -C srv.bare uploadpack.filter.tree.maxDepth 0 &&
test_must_fail ok=sigpipe git clone --no-checkout --filter=tree:1 \
"file://$(pwd)/srv.bare" pc3 2>err &&
test_i18ngrep "filter 'tree' not supported (maximum depth: 0, but got: 1)" err
+ test_config -C srv.bare uploadpack.filter.allow false
+ test_config -C srv.bare uploadpack.filter.tree.allow true
+ test_config -C srv.bare uploadpack.filter.tree.maxDepth 0
+ pwd
+ test_must_fail ok=sigpipe git clone --no-checkout --filter=tree:1 file:///home/szeder/src/git/t/trash directory.t5616-partial-clone.stress-4/srv.bare pc3
+ test_i18ngrep filter 'tree' not supported (maximum depth: 0, but got: 1) err
error: 'grep filter 'tree' not supported (maximum depth: 0, but got: 1) err' didn't find a match in:
Cloning into 'pc3'...
fatal: git upload-pack: banned object filter requested
error: last command exited with $?=1
not ok 20 - upload-pack limits tree depth filters
