On Wed, Jul 08, 2020 at 10:05:44AM -0700, Chris Torek wrote: > > I don't see anything within this function guaranteeing that rpos is set, > > either, though I suspect it is OK due to how the revision parser works. > > Yes, I am depending on the revision parser to balance the left and > right items. I thought about having a BUG check but it seemed > unnecessary. On the other hand, I'm avoiding depending on its > *placement* of left and right items. Being more defensive might > be good here. I could go either way with adding a BUG (and it definitely doesn't need to hold up this fix). I strongly suspect that getting a LEFT without a RIGHT would be a bug in the rev parser, not this code. But seeing a BUG() here might be a more friendly way of being informed of that than a segfault. :) -Peff
