On 7/9/2020 1:00 PM, SZEDER Gábor wrote: > 76ffbca71a (commit-graph: write Bloom filters to commit graph file, > 2020-04-06) added two delayed progress lines to writing the Bloom > filter index and data chunk. This is wrong, because a single common > progress is used while writing all chunks, which is not updated while > writing these two new chunks, resulting in incomplete-looking "done" > lines: > > Expanding reachable commits in commit graph: 888679, done. > Computing commit changed paths Bloom filters: 100% (888678/888678), done. > Writing out commit graph in 6 passes: 66% (3554712/5332068), done. > > Use the common 'struct progress' instance while writing the Bloom > filter chunks as well. Thanks for finding this. It's a clearly correct way to go, and is one of the things that did not get updated properly between the old prototype when applying it on the new code that included this ctx->progress pattern. Junio: head's up that this will conflict with the final patch in ds/maintenance. I'll remove my edits to these methods in my v2 to make that merge a bit easier. Thanks, -Stolee
