[PATCH] gc: fix some sparse 'symbol not declared' warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
---

Hi Derrick,

If you need to re-roll your 'ds/maintenance' branch, could you please
squash this into the relevant patches. The first hunk should be squashed
into commit a138b8ff61 (maintenance: create basic maintenance runner,
2020-07-07) and the second hunk into commit aca963ff39 (maintenance:
initialize task array and hashmap, 2020-07-07).

Thanks!

ATB,
Ramsay Jones

 builtin/gc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/builtin/gc.c b/builtin/gc.c
index c3531561c2..de029d687b 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -716,7 +716,7 @@ static const char * const builtin_maintenance_usage[] = {
 	NULL
 };
 
-struct maintenance_opts {
+static struct maintenance_opts {
 	int auto_flag;
 	int quiet;
 	int tasks_selected;
@@ -1297,9 +1297,9 @@ static int task_entry_cmp(const void *unused_cmp_data,
 	return strcasecmp(e1->name, name ? name : e2->name);
 }
 
-struct maintenance_task *tasks[MAX_NUM_TASKS];
-int num_tasks;
-struct hashmap task_map;
+static struct maintenance_task *tasks[MAX_NUM_TASKS];
+static int num_tasks;
+static struct hashmap task_map;
 
 static int compare_tasks_by_selection(const void *a_, const void *b_)
 {
-- 
2.27.0



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux