Han-Wen Nienhuys <hanwen@xxxxxxxxxx> writes: > On Wed, Jul 1, 2020 at 10:22 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: >> In any case, a patch that moves the existing "squash SPs and rtrim" >> cleansing from the files backend to the generic layer may look like >> the attached patch. We can add reftable backend on top of a change >> like this one and then we do not have to worry about each backend >> cleansing the incoming reflog messages the same way. Nice? > > Yes, very nice! Will you merge this, or should I make this part of > the reftable series? > The reftable code already has normalization for reflog messages, so it > doesn't really make a difference; either way is fine. It probably fits well in the "to prepare the existing code to support any new backend" series you have split out of the reftable series and sent separately earlier, not even "part of the reftable series", I think. With something like that, you may even be able to drop the custom reflog message munging from reftable proper, just like the whole point of the patch you are responding was to drop the custom munging from the files backend. Thanks.
