On Sat, Jul 4, 2020 at 5:28 PM Shourya Shukla <shouryashukla.oo@xxxxxxxxx> wrote: > > On 03/07 05:07, Johannes Schindelin wrote: > > In addition, as with all such changes, we need to be careful to consider > > whether unrelated function names coming in from system headers might > > clash. In this case, I think `count_lines()` is a bit too generic, but > > will probably not clash. Personally, I would probably have opted for > > `count_lines_in_string()`. > > I do not see it clashing with any other functions. Do we need to change > the name still (maybe to make the functions purpose even more clear)? This patch might not be needed at all according to Dscho's review of another patch in this series.
