On Wed, Jul 1, 2020 at 12:00 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > One other observation: To preserve bisectability (git-bisect) of > git.git itself, we want to ensure that the entire test suite still > passes at each point in a patch series. Making this change to the test > in its own patch introduces a failure into the test suite, which is > undesirable. One way to address this shortcoming would be to > temporarily change this test from 'test_must_succeed' to > 'test_must_fail', and then flip it back to 'test_must_succeed' in > patch 2/2. [...] And another correction: I meant 'test_expect_success' and 'test_expect_failure', respectively.
