On Wed, Jul 1, 2020 at 2:03 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Do you have an opinion on > > https://public-inbox.org/git/pull.665.git.1592580071.gitgitgadget@xxxxxxxxx/ > > ? > > > > There is some overlap with in sequencer.c, and Phillip's approach is > > likely more principled, so I'd like to base reftable on that. > > I assumed that these were offered to you as possible improvements to > be folded into your series, so I didn't read them very carefully and > I didn't queue them myself. I expected that I would see them, > possibly modified to fit the context better, as part of your series > sent from you, perhaps to become a part of early clean-up portion of > your topic. They are changing the signature of widely used functions, which is useful for my series but not completely necessary. I would rather that someone else decides on how to go forward with the series. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado