On Tue, Jun 30, 2020 at 4:56 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Tue, Jun 30, 2020 at 11:03 AM Denton Liu <liu.denton@xxxxxxxxx> wrote: > > + case "$1" in *?=*) ;; *) break ;; esac > > Isn't '*?=*' the same as '?=', or am I misunderstanding the intention? Nevermind. My brain blipped out while reading that. Obviously '?=' is not the same as '*?=*' here. The rest of the review comments still stand (I think).
