Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: >> reinit = create_default_files(... >> initial_branch ? initial_branch : "master", >> ...); >> if (reinit || initial_branch) >> warning(_(...)); >> >> in the previous step and then we can teach the caller to use the >> configured value instead of the hardcoded "master". > > While that is really tempting, there is another called of `init_db()` > (which calls `create_default_files()`): `builtin/clone.c`. And I do not > wish to duplicate the logic there. > > So I left this as-is. I am still on the fence after seeing v4, but let's leave it as is. The reason why I wanted to leave the "default to" logic out of the helper was to make sure it implements little or no policy, which would leave the door open to let other callers of the helper to use their own and different default, but we can revisit when we acquire the third caller. I do not see an immediate need to make the clone's fallback default configurable separately from what init uses for the default initial branch name, and with modern servers it is doubtful that the fallback default by clone is ever used anyway. Thanks.
