When we are dealing with a packet-line length header, we use the magic
literal `4`, representing the length of "0000" and "0001", the packet
line length headers. Use `strlen("000x")` so that we do not have to use
the magic literal.
Signed-off-by: Denton Liu <liu.denton@xxxxxxxxx>
---
remote-curl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/remote-curl.c b/remote-curl.c
index 75532a8bae..a2cbef546b 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -596,10 +596,10 @@ static int rpc_read_from_out(struct rpc_state *rpc, int options,
set_packet_header(buf - 4, *appended);
break;
case PACKET_READ_DELIM:
- memcpy(buf - 4, "0001", 4);
+ memcpy(buf - strlen("0001"), "0001", strlen("0001"));
break;
case PACKET_READ_FLUSH:
- memcpy(buf - 4, "0000", 4);
+ memcpy(buf - strlen("0000"), "0000", strlen("0000"));
break;
case PACKET_READ_RESPONSE_END:
die(_("remote server sent stateless separator"));
@@ -804,7 +804,7 @@ static int probe_rpc(struct rpc_state *rpc, struct slot_results *results)
curl_easy_setopt(slot->curl, CURLOPT_URL, rpc->service_url);
curl_easy_setopt(slot->curl, CURLOPT_ENCODING, NULL);
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDS, "0000");
- curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE, 4);
+ curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE, strlen("0000"));
curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, headers);
curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer);
curl_easy_setopt(slot->curl, CURLOPT_FILE, &buf);
--
2.27.0.307.g7979e895e7
