On Fri, Jun 19, 2020 at 12:20:38PM -0700, Junio C Hamano wrote: > >> <shrug> The names were long enough that I thought it was more clear not > >> to repeat myself. [...] > > > > Indeed, it's a minor point and subjective. Certainly not worth a > > re-roll or even worrying about it. > > It probably is subjective but fwiw I too find yours easier to > follow. I ended up doing it this way, since I decided to quote the pathnames (and thus they needed their own fprintf, at which point there was really nothing left for the two to share). > > Hmph, that shouldn't have failed. Did you quote the $(wc -l refs) > > invocation? Quoting it would cause it to fail. > > > + git show-ref >refs && > > + nrefs=$(wc -l <refs) && > > Yup, I've seen that workaround for macs too many times and it should > work well. I switched to this style in the re-roll (and ditto for the path output, which actually turned up a bug). -Peff
