On Fri, Jun 19, 2020 at 11:04:44AM -0400, randall.s.becker@xxxxxxxxxx wrote: > From: "Randall S. Becker" <rsbecker@xxxxxxxxxxxxx> > > strbuf_write_fd was only used in bugreport.c. Since that file now uses > write_in_full, this method is no longer needed. Just because there are no callers _now_ does not necessarily mean that it's a good idea to get rid of a function. I think the real argument is that we don't expect new ones, because it's a badly designed function (for the reasons in our earlier discussion). Maybe worth summarizing here. -Peff
