Hi, On Wed, 17 Jun 2020, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > I'm not sure if this check_refname_format() is valid, though. IIRC we've > > had issues where "ONELEVEL" was used to check a branch name, but misses > > some cases. The more full check done by strbuf_check_branch_ref() > > actually creates the full refname and checks that. It also catches stuff > > like refs/heads/HEAD. > > Yup. > > I actually am in favor of removing special casing of a single branch > done by fmt-merge-msg and fast-export --anonymize, so this may not > matter. > > We still need a mechanism to allow users specify the default name to > be given to the first branch "git init" creates and used by "git clone" > as a fallback name when it cannot infer what the other side uses, though. All right, `core.mainBranch` will go, then, and `init.defaultBranch` will stay and I will check the full ref. Thank you for your help improving the patch series, Dscho
