Re: [PATCH 4/4] clean: optimize and document cases where we recurse into subdirectories

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Catching up on this - thanks Elijah for jumping on this bug and fixing
it immediately. I'll let you know if I see similar bugs in the future.

Thanks,
Brian

On Fri, Jun 12, 2020 at 5:28 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> "Elijah Newren via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>
> > ...
> > However, in clean's case we don't need to recurse into ignored
> > directories; that is just a waste of time.
>
> Nice.
>
> > Rather than relying on other bugs in fill_directory()'s former
> > logic to provide the behavior of skipping ignored directories, make use
> > of the DIR_SHOW_IGNORED_TOO_MODE_MATCHING value specifically added in
> > commit eec0f7f2b7 ("status: add option to show ignored files
> > differently", 2017-10-30) for this purpose.
>
> Thanks.
>



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux