Re: [PATCH v4 4/8] cmake: support for testing git with ctest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +
> +if(BUILD_TESTING)
> +

This variable should perhaps be declared as an option using option()[1] since
it's a knob the user is supposed to be able to switch. This makes it listed by
`cmake -L`, and shown in ccmake and cmake-gui. In short, it's made more
disoverable.

> file(APPEND ...)
> file(APPEND ...)
> file(APPEND ...)
> (...)

Maybe make this one multiline string and have one file(APPEND ...) at the end?
It looks a bit... big.

Øsse

[1]: ttps://cmake.org/cmake/help/v3.18/command/option.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux