On Wed, Jun 10, 2020 at 8:59 PM Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > I am reasonably sure we use opendir() to iterate over existing files > > and subdirectories in a directory (e.g. in the codepaths to > > enumerate loose object files in .git/objects/??/ directories). > > > > I do not offhand know we also use fdopendir() elsewhere. I strongly > > suspect we do not. Perhaps some platforms do POSIX.1-2001 but not > > ready for POSIX.1-2008 or something silly like that? > > We don't. We also do not use `unlinkat()`. And we generally use > `remove_dir_recursively()` instead of implementing a separate version of > it that only handles one directory level ;-) > > This is what I needed in Git for Windows' `shears/pu` branch to make it > compile again: Thanks Dscho. Last time I folded a fix into github.com/google/reftable, you seemed quite upset. How should I proceed with this fixup? -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
