On 2020-06-08 at 16:47:58, Junio C Hamano wrote: > Brian, I notice that the singleton global "marks_set_count", even > though the number could be counted per instance of the mark_set > structure, is still singleton. I didn't bother thinking about it > when I wrote my "perhaps along this line" patch, but now I read it > again, I think it is OK to leave it (and other stats counters) as > is, primarily because we don't have a need (yet) to show stats per > mark_set. Did you leave it as a global for the same reason? Just > sanity-checking. Yes, I did; sorry for not mentioning that in the commit message. I think it's fine to count the total number of marks processed as a statistic, and that would be independent of how we processed them. It's an interesting metric, but not so interesting that folks will have a need to see a detailed breakdown, I think. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
