Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> writes: > Hi Junio, > > I have done the suggested changes namely: > 1) Format code inside check_c_source_compiles/runs > 2) Moved the changelog of the patch series from the commit messages to > the cover letter > 3) parse for SCRIPT_LIB > 4) glob templates and po files > 5) add logic as to where the template file should be built. > > Any other changes I should do before I a new version of the patch series? > > Thank You, > Sibi Siddharthan Sorry, but I read too many patch series that I do not remember glitches I pointed out in the previous round of individual topics. So asking that question is waste of both of our times. Just use the time necessary to compose that message to instead proofread one more time, scan the review thread of previous round and make sure you took everybody's input into consideration (you do not have to follow everything other people said---you just need to be able to solidly stand behind the decision you made to follow or not follow them in your latest version). Thanks.
