"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > We don't actually hit this case in any of the tests because we don't > have any tests that have 1024 marks in them. I'm having trouble coming > up with a test even with a large number of marks because I don't think > we produce different behavior here; we just leak a lot of memory. > > This does fix the reported issue, as I suspected. > > Do you want to write this up into a patch with a commit message, or > should I? If the latter, may I have your sign-off for it? Sure, anything I write for this project you can assume to be signed off by me. As I was just "fixing" what I thought was a botched conversion, without really figuring out where it actually leads to leaks, I'd need further work if I were to wrap it up with a sensible log message, so thanks for volunteering ;-) Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
