Re: [PATCH 04/34] commit-slab: add a function to deep free entries on the slab

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 04/34] commit-slab: add a function to deep free entries on the slab
From: Derrick Stolee <stolee@xxxxxxxxx>
Date: Thu, 4 Jun 2020 12:43:32 -0400
Cc: Junio C Hamano <gitster@xxxxxxxxx>, Garima Singh <garima.singh@xxxxxxxxxxxxx>, Jakub Narebski <jnareb@xxxxxxxxx>, Jeff King <peff@xxxxxxxx>, Taylor Blau <me@xxxxxxxxxxxx>
In-reply-to: <20200529085038.26008-5-szeder.dev@gmail.com>
References: <20200529085038.26008-1-szeder.dev@gmail.com> <20200529085038.26008-5-szeder.dev@gmail.com>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Thunderbird/77.0

On 5/29/2020 4:50 AM, SZEDER Gábor wrote:
> +void free_depth_in_slab(int **ptr)

This needs to be "static" to compile with DEVELOPER=1.

(I'm working to apply your patches on top of ds/line-log-on-bloom
so we can get the benefit of these universally-good things. I just
want to report the things that I stumble on.)

Thanks,
-Stolee

Follow-Ups:
- Re: [PATCH 04/34] commit-slab: add a function to deep free entries on the slab
  - From: SZEDER Gábor

References:
- [PoC PATCH 00/34] An alternative modified path Bloom filters implementation
  - From: SZEDER Gábor
- [PATCH 04/34] commit-slab: add a function to deep free entries on the slab
  - From: SZEDER Gábor

Prev by Date: Re: [PATCH] sparse-checkout: avoid staging deletions of all files
Next by Date: Re: [PATCH] sparse-checkout: avoid staging deletions of all files
Previous by thread: [PATCH 04/34] commit-slab: add a function to deep free entries on the slab
Next by thread: Re: [PATCH 04/34] commit-slab: add a function to deep free entries on the slab
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]