Possible regression in `git grep --untracked` pathspec matching in v2.27.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In v2.26.2 and earlier, `git grep --untracked` with negative pathspec patterns
would filter out paths matching those patterns. In v2.27.0, this no longer works
as expected.

Example output:

# v2.26.2 (good)
$ ./git grep --untracked --files-with-matches -e '.' -- 'quote.*' ':!quote.c'
quote.h
$

# v2.27.0 (bad)
$ ./git grep --untracked --files-with-matches -e '.' -- 'quote.*' ':!quote.c'
quote.c
quote.h
$

I've bisected the change to commit 95c11ecc73f286e0a95d9591ae98f1221efe4633,
which changed the handling of path matches in callers of `fill_directory()`.

It's not clear from git-grep(1) whether the old or new behavior is "correct",
so I request that the fix include a clarification of expected semantics.

Thanks,
- John Millikin



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux