On 6/1/2020 2:01 PM, Taylor Blau wrote: > Here's a short pair of patches that I wrote this morning after looking > at Stolee's most recent coverage report. > > The first patch is just cleanup, and the second patch is the real > change. It would have been nice to parameterize these tests over the > arguments to 'git commit graph' (ie., have three tests for 'write', > 'verify', and 'write --stdin-commits'), but '--stdin-commits' is special > since it requires input. > > These patches are based off the tip of 'next', but really only need my > changes from 'tb/commit-graph-no-check-oids'. The first patch is an obviously good patch, and it even has a good justification in the message. The second is also good. The case of forcing "--progress" would be enough for covering your new-ish progress meter. Perhaps the other tests (or at least the one specifying "--no-progress") could be removed, but I don't feel strongly about that. Thanks, -Stolee
