Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> writes: > On Sat, May 30, 2020 at 12:57 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: >> ... >> Everything after the "Changes" line does not belong to the commit >> log, as it is no use for those who read "git log" output and >> encounter the "first" attempt to add CMake support there. There is >> no need to tell them that you did things differently from this >> version in the past, as they simply do not know what you did in the >> previous iterations, nor particularly care about them. >> >> These *do* help reviewers who saw previous iterations, and the space >> after the three-dash line below is the right/recommended place for >> them. >> >> The above applies to other patches in this series. > > Do you mean this line '---' below? Yes. > If so how do I place the changelog below them? > I just do `/submit` at gigitgadet/git. Sorry, I don't use GGG, so the question needs to be redirected to those who do and enhance (Dscho cc'ed). >> > Signed-off-by: Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> >> > --- Here is what I meant, but another place that is suitable to describe differences from previous rounds is the cover letter. If the split of tasks between steps in a multi-patch series hasn't changed from the previous round, it makes it easier to review if the changes since the last round for each individual step is described in the message itself, like you did. It just needs to be done outside the log message. Thanks.
