On 2020-05-31 00:34:52+0530, Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> wrote: > > Anyway, there're test is failing in Linux with this CMake. > > > > $git_repo/t/../build/bin-wrappers/git is not executable; using GIT_EXEC_PATH > > > > It looks like CMake Generator forgets "chmod +x bin-wrappers/git" > > > > CMake does not support changing permissions of files easily. > You have to juggle them around to a temporary location and > change the permissions when you do `file(COPY ...)`. Does it work better to use `configure_file` and `file(COPY)` > > OK, so this maybe the pain point, let me build in source again. > > Hm, no, I still see the same problems. > > Worse, CMake overrides my current Makefile. > > Luckily, I don't have any changes in Makefile. > > > > Please read the next PATCH, it supports out of source building and testing. It's the remind to NOT mess with Git's Makefile ;) > > > +endif()#BUILD_TESTING > > > > We can use: > > > > endif(BUILD_TESTING) > > > > The docs suggest that this way of endif() is for backwards compat only. > Not sure if I should change this, as CMake might remove this in the > future(very unlikely though). I don't have strong opinion for this syntax. -- Danh
