On Sat, May 30, 2020 at 7:44 PM Đoàn Trần Công Danh <congdanhqx@xxxxxxxxx> wrote: > > On 2020-05-29 13:40:24+0000, Sibi Siddharthan via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > To check for ICONV_OMITS_BOM libiconv.dll needs to be in the working > > directory of script or path. So we copy the dlls before we configure. > > If ICONV_OMITS_BOM is such a troublemaker for CMake, > I'm fine with not supporting it at all. > > It seems like noone except me have interest in ICONV_OMITS_BOM. > It is not a problem supporting this check. This check has to be implemented sometime down the road.(as it is specified in the Makefile) The issue currently is that this check is a bit big (~50 loc) including setup and cleanup. This might be a burden for the reviewers as the only reason for considering CMake support is to support windows developers. > > @@ -302,4 +308,4 @@ jobs: > > steps: > > - uses: actions/checkout@v1 > > - run: ci/install-dependencies.sh > > - - run: ci/test-documentation.sh > > + - run: ci/test-documentation.sh > > \ No newline at end of file > > Please fix your editor ;) > > -- > Danh
