"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> From: Han-Wen Nienhuys <hanwen@xxxxxxxxxx>
>
> Both the git-bisect.sh as bisect--helper inspected the file system directly.
>
> Signed-off-by: Han-Wen Nienhuys <hanwen@xxxxxxxxxx>
> ---
> builtin/bisect--helper.c | 3 +--
> git-bisect.sh | 4 ++--
> 2 files changed, 3 insertions(+), 4 deletions(-)
Makes sense.
A topic that adds more callers to the git_path_bisect_head()
function has already been in flight for quite a while; I wonder if
we can meet the topic in the middle. For example, would it have
helped if we had a helper like this one:
static inline int bisect_head_exists(void) {
return ref_exists("BISECT_HEAD");
}
on this side, and have the other side have something like:
static inline int bisect_head_exists(void) {
return file_exists(git_path_bisect_head());
}
Then the caller(s) of bisect_head_exists() don't have to be changed
at all.
Anyway, it's just a lesson that communication and collaboration
between developers may help coming up with correct integration
results.
Thanks. Queued.
