On Wed, May 27, 2020 at 06:47:40PM +0200, Christian Couder wrote: > As we cleanup 'upload-pack.c' by using 'struct upload_pack_data' > more thoroughly, let's move the 'allow_ref_in_want' static > variable into this struct. > > It is only used by protocol v0 code since protocol v2 assumes > certain baseline capabilities, but rolling it into > upload_pack_data and just letting v2 code ignore it as it does > now is more coherent and cleaner. I think this is opposite, isn't it? Ref-in-want is a v2-only feature, and v0 does not support it at all (though it could). -Peff
