On Wed, May 27, 2020 at 06:47:33PM +0200, Christian Couder wrote: > As we cleanup 'upload-pack.c' by using 'struct upload_pack_data' > more thoroughly, let's move the 'use_sideband' static variable > into this struct. > > This variable is used by both v0 and v2 protocols. > > While at it, let's update the comment near the variable > definition. Yep, looks good. I was surprised for a moment by "used by v2", which always does sideband. But of course we still _use_ the variable, we just set it unconditionally in the v2 code-path. -Peff
