Re: [PATCH v3 4/5] rebase -i: support --ignore-date

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Danh

On 24/05/2020 00:05, Đoàn Trần Công Danh wrote:
Hi Phillip,

On 2020-05-23 19:50:40+0100, Phillip Wood <phillip.wood123@xxxxxxxxx> wrote:

The part of my reply you've cut said "I've checked the log invocations in
the other tests and I think they're all OK." So it is just the one that you
pointed out that needs to be fixed up (the others without -1 are all
checking the result of rebase --root). I'm happy to re-roll if Junio wants -
lets wait and see what he says.

Ah, I was thinking "they're all OK" meant that part can be left as-is,
and the only part need to change is the --pretty=format.

Sorry for the noise, (and my bad in reading).

Looking at the patches again I think I misunderstood what you were saying - I had not twigged that I needed to remove the 'format:' from all the git log invocations. I'll send a reroll later.

Sorry for the confusion

Phillip



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux