On 2020-04-23 09:06:55+0200, Miriam Rubio <mirucam@xxxxxxxxx> wrote: > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > index 0fbd924aac..d3b2b33df0 100644 > --- a/builtin/bisect--helper.c > +++ b/builtin/bisect--helper.c > @@ -74,6 +74,28 @@ static int one_of(const char *term, ...) > return res; > } > > +static int write_in_file(const char *path, const char *mode, const char *format,...) Nit: It looks like we want to add a space in the end ", ...)" Since "one_of" above also has that space. Otherwise, look good. -- Danh