On Wed, May 20, 2020 at 04:59:29PM -0700, Junio C Hamano wrote: > Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > > > Speaking of which, should we enable protocol v2 by default for people > > with feature.experimental enabled, like this? > > It is an excellent idea, but is something that had to have been > proposed before -rc0 to be in the upcoming release, no? Yeah, my original email was almost "hey, did we make a conscious decision to keep v2 reverted after we found the root cause?". But I think it is too late in the -rc cycle to switch now (which is kind of a shame, because we won't really get good data on whether the in_vain fix helped the Linux folks, since it seems clear that most of them are not switching protocol.version themselves). The feature.experimental one we could be a bit more cavalier with, though. I dunno. (I guess you could argue that since v2.26.2 shipped with protocol v2, we could already be pretty cavalier with _leaving_ it on in the new release, but I think as a general principle -rc2 is not the right time to go flipping defaults). -Peff
