I recently had an issue with git-rebase, and actually git-am, kind of hard to track down. After some hassle to understand what was going on, it happened that for an idiotic reason (me trying a fancy new login manager for X that didn't cleansed environment before staring X) made all my env dirty. In particular it had $resume (in small letters) set to /dev/sda5, and git-am happens to use the very same variable, without cleansing the environment. I'm maybe completely out of luck, and that's the sole unsafe use of variables in git shell scripts, but I don't think so, and maybe some kind of failsafe could be used. A crude way is to call: unset `env | cut -d= -f1 | grep -v [A-Z]` at the beginning of every script, so that every lowercase-only variables are unset, hence can be safely used. But it's completely tasteless. Though, as it can really lead to _very_ odd bugs, well, I just wanted to share the issue. For the curious, you can read on [0] what the issue looked like for me... [0] http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=38;bug=435807#38 Cheers, -- ·O· Pierre Habouzit ··O madcoder@xxxxxxxxxx OOO http://www.madism.org
Attachment:
pgphQEFgQdgQq.pgp
Description: PGP signature
