On 2020-05-19 09:13:19+0200, Christian Couder <christian.couder@xxxxxxxxx> wrote: > On Tue, May 19, 2020 at 3:00 AM Đoàn Trần Công Danh > <congdanhqx@xxxxxxxxx> wrote: > > > We can also copy-and-paste code from t4019, > > to avoid introduce perl to this test. > > This might be a good idea. Probably we need 2 patches, one to libify the current usage in t4019, one to replace "grep -a" usage in t5703. Consider this is floating for a long time, I think we can hold this for the time being, until after 2.27.0 released. > > t/t5703-upload-pack-ref-in-want.sh | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/t/t5703-upload-pack-ref-in-want.sh b/t/t5703-upload-pack-ref-in-want.sh > > index a34460f7d8..92ad5eeec0 100755 > > --- a/t/t5703-upload-pack-ref-in-want.sh > > +++ b/t/t5703-upload-pack-ref-in-want.sh > > @@ -49,15 +49,18 @@ test_expect_success 'setup repository' ' > > > > test_expect_success 'config controls ref-in-want advertisement' ' > > At least you should add the PERL prereq to the test with something like: > > test_expect_success PERL 'config controls ref-in-want advertisement' ' Well, that's is not t/README says: - PERL Git wasn't compiled with NO_PERL=YesPlease. Even without the PERL prerequisite, tests can assume there is a usable perl interpreter at $PERL_PATH, though it need not be particularly modern. And, there're a lot of tests using perl without PERL prereq: $ git grep -l '[ ]perl ' 't/t????-*.sh' | wc -l 55 $ git grep -l PERL 't/t????-*.sh' | wc -l 35 -- Danh
