On Fri, May 15, 2020 at 12:43 PM Derrick Stolee <stolee@xxxxxxxxx> wrote: > > On 5/15/2020 6:04 AM, Christian Couder wrote: > > While there are still a lot of static variables at the top of > > 'upload-pack.c' after this patch series, it does a lot of ground work > > and a number of cleanups. > > The patches here are carefully organized to make review easy. Thanks! > > I was surprised to see how many local or static variables you were able > to remove using members that already existed in 'struct upload_pack_data'. > That made the changes here particularly easy to trust. > > Reviewed-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> Thanks for your review and kind words! I would very much like to add your "Reviewed-by:" to this patch series, but as no suggestion has been made to improve it, I am a bit reluctant to resend with only your "Reviewed-by:" added. Junio, what would you prefer? Thanks, Christian.
