This is a reroll for cb/t4210-illseq-auto-detect that includes all feedback and split on two steps for easy of reviewing. While the refactoring in test-regex.c is a little more intrusive that needed, makes the logic easier to follow and the different use cases more straightforward. Note that there is still a leak in the use of regex_t, and had kept all original assumptions for simplicity (no explicit check on REG_ILLSEQ, or unlikely differences between BASIC/EXTENDED). Carlo Marcelo Arenas Belón (2): t/helper: teach test-regex to report pattern errors (like REG_ILLSEQ) t4210: detect REG_ILLSEQ dynamically and skip affected tests t/helper/test-regex.c | 94 ++++++++++++++++++++++++++++++------------- t/t4210-log-i18n.sh | 77 ++++++++++++++++++++++++++--------- t/test-lib.sh | 6 --- 3 files changed, 125 insertions(+), 52 deletions(-) -- 2.27.0.rc0.183.gde8f92d652