On Fri, May 15, 2020 at 12:04:48PM +0200, Christian Couder wrote: > As we cleanup 'upload-pack.c' by using 'struct upload_pack_data' > more thoroughly, let's use the 'struct packet_writer writer' > field from 'struct upload_pack_data' in receive_needs(), > instead of a local 'struct packet_writer writer' variable. Makes sense. I don't think the writer carries any packet state between phases that would confuse us by using the same one. I did wonder how its use_sideband flag works, but it looks like we only set that in v2 when we see sideband-all. So for v0, it wouldn't affect us either way. -Peff
