On Fri, May 15, 2020 at 12:04:43PM +0200, Christian Couder wrote: > As we cleanup 'upload-pack.c' by using 'struct upload_pack_data' > more thoroughly, let's move the want_obj and have_obj object > arrays into 'struct upload_pack_data'. > > These object arrays are used by both upload_pack() and > upload_pack_v2(), for example when these functions call > create_pack_file(). We are going to use > 'struct upload_pack_data' in upload_pack() in a followup > commit. Makes sense. The v2 code path is slightly messier now (having to dereference "data" more), but this should all pay off later in the series when we can get rid of v0 globals. -Peff