Guillaume Galeazzi <guillaume.galeazzi@xxxxxxxxx> writes: > Goal here was to avoid magic number, but after looking to the code it > seem accepted that true is 1 and false is 0. To comply with that, in > next version it will be replace it with: > > if (FOREACH_BOOL_FILTER_NOT_SET != info->active_only) { It still is unusual to have a constant on the left hand side of the "!=" or "==" operator, though. Having a constant on the left hand side of "<" and "<=" is justifiable, but not for "!=" and "==".