On Wed, May 13, 2020 at 2:57 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > "Sibi Siddharthan via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > From: Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> > > Subject: Re: [PATCH v2 11/11] ci: modification of main.yml to use cmake for vs-build job > > Yay! > > > This patch modifies .github/workflows/main.yml to use CMake for > > Visual Studio builds. > > Modified the vs-test step to match windows-test step. This speeds > > Teach .github/workflows/main.yml to use Cmake for VS builds. > Modify vs-test step to match windows-test step to speed up > the vs-test. > > > Changes: > > The CMake script has been relocated to contib/buildsystems, so point > > to the CMakeLists.txt in the invocation commands. > > This does not belong to the log message for this (or any for that > matter) commit, no? Up to this point, nothing in main.yml used > CMake script from anywhere, and "has been relocated" is irrelevant. > Will remove this. > And if we add CMake script to contrib/buildsystems/ from the > beginning in [01/11], there won't be any "relocation" the readers of > the log message of this step need to know about. > > > The generation command now uses the absolute paths for the generation > > step. > > "now uses"? Is that something the readers of the log message of > this step need to know about, or is it "in contrast to an earlier > attempt to add CMake script"? If the latter, it only confuses the > readers of our history, as most of them will not even know about an > earlier attempt. Will also remove this. > > Thanks. Thank You, Sibi Siddharthan
