Jeff King <peff@xxxxxxxx> writes: > On Mon, May 11, 2020 at 09:46:34AM -0700, Junio C Hamano wrote: > >> Lest we all forget... >> >> -- >8 -- >> Subject: git-jump: just show the list with the "--no-editor" option > > Thanks for tying this up. It seems to work as advertised. A few nits: > >> +edit=yes >> + >> +while case "$#,$1" in > > Tab between "while" and "case"? Yup. Just to align case and its arms. >> + 0,*) break ;; >> + *,--no-editor) edit=no ;; >> + *,--*) usage >&2; exit 1 ;; >> + *) break ;; >> + esac >> +do >> + shift >> +done > > I found the use of "case" in the loop conditional a little unusual. It's pretty-much personal preference, I think. I could replace s/break/false/ if you find it easier to understand. > It probably doesn't matter much, but we could skip the tempfile entirely > in no-editor mode. I.e.: > > if test "$edit" = "no" > then > "mode_$mode" "$@" > fi > > # otherwise set up trap, mktemp, etc Makes a lot of sense to me.
