Re: [PATCH 1/2] t5551: test that GIT_TRACE_CURL redacts password

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/2] t5551: test that GIT_TRACE_CURL redacts password
From: Jeff King <peff@xxxxxxxx>
Date: Tue, 12 May 2020 15:08:31 -0400
Cc: git@xxxxxxxxxxxxxxx
In-reply-to: <bee4fc7241596a6b4206fa8b52dfdaea88180f37.1589218693.git.jonathantanmy@google.com>
References: <cover.1589218693.git.jonathantanmy@google.com> <bee4fc7241596a6b4206fa8b52dfdaea88180f37.1589218693.git.jonathantanmy@google.com>

On Mon, May 11, 2020 at 10:43:09AM -0700, Jonathan Tan wrote:

> Verify that when GIT_TRACE_CURL is set, Git prints out "Authorization:
> Basic <redacted>" instead of the base64-encoded authorization details.

Yeah, it's definitely worth testing this. The patch looks good to me.

-Peff

References:
- [PATCH 0/2] Safer GIT_CURL_VERBOSE
  - From: Jonathan Tan
- [PATCH 1/2] t5551: test that GIT_TRACE_CURL redacts password
  - From: Jonathan Tan

Prev by Date: Re: git-gui patch staging errors
Next by Date: Re: [PATCH 2/2] http, imap-send: stop using CURLOPT_VERBOSE
Previous by thread: [PATCH 1/2] t5551: test that GIT_TRACE_CURL redacts password
Next by thread: [PATCH 2/2] http, imap-send: stop using CURLOPT_VERBOSE
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux