George Brown <321.george@xxxxxxxxx> writes:
> contrib/git-jump: cat output when not a terminal
>
> The current usage to populate Vim's quickfix list cannot be used from
> within the editor as it invokes another instance.
>
> Check if stdout is to a terminal or not. If not simply cat the output.
The are editors that open their own window, or tell an already open
editor instance to edit the buffer (think: emacsclient) and in order
to be functional, they do not have to be launched from inside a
working terminal window (whose input comes from the keyboard---the
test "-t 1" is an approximate check for that).
Wouldn't this change hurt the users of such an editor?
Would it work to set GIT_EDITOR to "cat" while performing the
"populating quickfix list" (whatever that is) operation?
> Signed-off-by: George Brown <321.george@xxxxxxxxx>
> ---
> contrib/git-jump/git-jump | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/git-jump/git-jump b/contrib/git-jump/git-jump
> index 931b0fe3a9..253341c64e 100755
> --- a/contrib/git-jump/git-jump
> +++ b/contrib/git-jump/git-jump
> @@ -19,8 +19,12 @@ EOF
> }
>
> open_editor() {
> - editor=`git var GIT_EDITOR`
> - eval "$editor -q \$1"
> + if test -t 1; then
> + editor=`git var GIT_EDITOR`
> + eval "$editor -q \$1"
> + else
> + cat "$1"
> + fi
> }
>
> mode_diff() {
