"Son Luong Ngoc via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Son Luong Ngoc <sluongng@xxxxxxxxx> > > As the old versions of dash is deprecated, dollar-sign inside > artihmetic expansion is no longer needed. > This ensures t5319 follows the coding guideline updated > in 'jk/arith-expansion-coding-guidelines' 6d4bf5813cd2c1a3b93fd4f0b231733f82133cce. That does not match my understanding of the guideline. By removing the "dollar required" rule and not adding a new "dollar forbidden" rule, we pretty much declared that "we do not care much either way" [*1*]. Even if we cared, "Once it _is_ in the tree, it's not really worth the patch noise to go and fix it up." rule from the guidelines applies here. Thanks. [Reference] *1* https://lore.kernel.org/git/20200505210741.GB645290@xxxxxxxxxxxxxxxxxxxxxxx/
